Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Make a Copy" does not copy attached files #2741

Open
httpdev opened this issue Mar 18, 2020 · 2 comments
Open

"Make a Copy" does not copy attached files #2741

httpdev opened this issue Mar 18, 2020 · 2 comments
Labels

Comments

@httpdev
Copy link

httpdev commented Mar 18, 2020

On alpha.iodide.io revision 1d87c1a, when the user clicks on "Make a Copy", the notebook is cloned, but none of the files attached to it, which may prevent the notebook from working.

What I Did

  1. Create a new notebook
  2. Go to Files > Add a file, say "test.png"
  3. Verify that the file is accessible under /notebooks/<notebook_id>/files/test.png
  4. Click on "Make a Copy"
  5. With the new notebook, check if the file is accessible unter /notebooks/<Copy_of_notebook_id>/files/test.png

What I Expected

The file should display.

What Happened

500 Internal Server Error message

(if applicable) notebook that reproduces bug

Original notebook: https://alpha.iodide.io/notebooks/4281/files/kaefer.png
Copy: https://alpha.iodide.io/notebooks/4283/files/kaefer.png

@wlach wlach added the bug label Apr 6, 2020
@wlach
Copy link
Contributor

wlach commented Apr 6, 2020

Yes this is a known issue, but I don't think we had an issue open for it. Thanks for filing!

@susan-shu-c
Copy link

Taking a quick look, seems to be able to add that in here?

Possibly with the help of this or something in /src/shared/utils/file-operations.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants