-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print whole report to PDF #2563
Comments
@mehmetoguzderin as I mentioned in the meeting, I think it might be worth trying to print just the iframe using the window.print command: https://developer.mozilla.org/en-US/docs/Web/API/Window/print The mechanism to call this would be the eval frame's port to the editor: We could experiment with adding a "Print" button beside "Explore" in report view, and adding an option to the menu in explore view. Are you interested in giving this a try? It might not be that difficult if we're lucky... |
@wlach Yes, I would like to try it on the weekend. |
Excellent! I'll assign this to you for now |
@wlach Great! |
re UI/UX, i think we need a better approach than adding another button in the top corner. but it looks like maybe we can intercept attempts to print and trigger custom logic, so maybe we don't need to change the UI at all?-- |
Yeah agreed, that was just a suggestion for a first pass.
That sounds perfect! The best UI is no UI. |
fwiw: off the top of my head, i think the way to do thiswould be something like: assuming the
|
Unfortunately |
I'm opposed to adding another button to the report view -- we want the report to be as clean as possible, and to focus on user content, and we therefore we want to be very judicious about adding anything anything in that view. My belief is that for an online-first communication tool, print functionality will be very niche, so adding clutter to the report view to support it is not a worthwhile trade-off. @mehmetoguzderin can you clarify what you mean about " Perhaps we can try a printing stylesheet or media query: |
I understand the sentiment (and agree with it) but IMO, hiding a print option behind a |
When converting to PDF using browser's printing functionality, due to iframe, it produces a cropped page. Correction of this functionality is important for contexts that have more traditional measures but open to converting from any platform.
Example notebook:
https://alpha.iodide.io/notebooks/3427/?viewMode=report
The text was updated successfully, but these errors were encountered: