Fix No Warning on Browser Button Navigation(Fixes #2403) #2529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here we just check for push state in history if a back navigation, or page refresh is called from the browser when a change is made. This can also be triggered by catching the overall onbeforeunload event. |
Codecov Report
@@ Coverage Diff @@
## master #2529 +/- ##
==========================================
- Coverage 71.08% 69.84% -1.24%
==========================================
Files 238 223 -15
Lines 5841 5515 -326
Branches 935 887 -48
==========================================
- Hits 4152 3852 -300
+ Misses 1670 1644 -26
Partials 19 19
|
|
this works for me, thanks @Algentile. I've been thinking about the interaction model, and I think we can continue to refine it along the lines of what i mentioned in this this comment #2403 (comment) but this is a great step in preventing people from losing work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Instance can be found https://local-iodide.herokuapp.com/ for QA. This is a change to resolve #2403.
Pull Request checklist