Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should update userDefinedVarNames in state even when eval errors #2345

Open
bcolloran opened this issue Oct 8, 2019 · 0 comments
Open

Should update userDefinedVarNames in state even when eval errors #2345

bcolloran opened this issue Oct 8, 2019 · 0 comments

Comments

@bcolloran
Copy link
Contributor

currently, userDefinedVarNames only updates after an eval that runs to completion without error, but variables can be successfully defined even if the chunk errors overall. see this NB, watch the workspace pane:
https://alpha.iodide.io/notebooks/3404/

i think this is a quick fix in eval-queue-saga.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bcolloran