-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebook history does not handle single new line #2260
Comments
This sounds like a bug in |
@wlach @mehmetoguzderin created a new issue #2275 about moving off of |
I think I can try it out! |
Revision browser does not show one new empty line as difference. The new line is detected correctly, saved but the difference is not visible in the revision browser, instead it only shows "Expand x lines ..." option. There are no problems with more than one empty new lines.
Steps to Reproduce
Cause of the Problem
This problem is caused by the handling of
diff
module's output byreact-diff-viewer
module atconstructLines
function incompute-lines.js
. If emptiness check and first-last modification disabled, behavior matches the expectation (Iodide system registers those new lines as change, as it should be).react-diff-viewer
provides no way to change this behavior.The text was updated successfully, but these errors were encountered: