-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using Ranges for external editor modifications #6
Comments
@DevinBayly can you point me at the code you have so far so i can see how you're thinking about this? i think we'll need to do a bit of surgery to get this working. there are a couple ways we could do it --
|
oof, haven't put code down to this yet. I was mostly wandering through the src tree in iodide looking for clues about how information in the state triggers changes down stream in areas I care about like the editor. I sort of believed there could be some more info on the editor state than just line, col, like "range", but i didn't know how the text to include in the range was meant to look so I put up this issue to get your thoughts. I agree that option 1 seems like the best way to go. It's just a matter of making the editor visible to the reducer scope right? Perhaps I'm jumping the gun and the reducer is only meant to update the state and that will ultimately trigger the correct changes though, and then we are back to my suggestion above. Either way some surgery is likely needed as you say. |
yea the way the data flow is meant to work in a redux app is that you update the app state and the presentational components (in this case the Monaco instance) will update based on that. that part of the pipeline should be working already -- if we update |
gotcha, yes the basic presentational updates are in working order. I think I need some suggestions about where to look to better understand how the monaco instance handles a change in the |
This issue relates to an attempt to send information about multicharacter ranges to iodide from the external editor. What has me the most stuck at the moment is where to start in terms of creating a reducer that can actually access and make calls to the monaco editor instance running in the Iodide Notebook. @bcolloran any thoughts to offer here?
The text was updated successfully, but these errors were encountered: