-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rules and/or Guidelines] grammar issues in rules/guidelines #33
Comments
Would it help if I made a new issue for the other one? Or just make a comment with the issues (copied over) for each one? I need to leave for a bit now .. unsure if I can resume this today or not. |
We the rules and guidelines are somewhat connected, a single issue for both is OK. |
Thanks! First I have to finish the rule 17 related issues. Then I will do the change in the temp test repo. Then after that is merged I can delete that fork and fork this repo and do it. Of course I can start working on this before the merge: assuming I have the energy: it was a really hard night and I have a lot of other things to do first (although making great progress). I will be able to continue working on the rule 17 issues soon I hope. |
BTW: We modified Rule 13 and the related text in the guidelines (as well as the news) as part of commit 9dd70f0
Best wishes on a better night tomorrow @xexyl . |
Thanks for the warning!
Thank you. But at least despite this I made great progress today (related to rule 17)! |
This comment was marked as outdated.
This comment was marked as outdated.
And I hope to look at this issue tomorrow btw. |
We made a post to the wrong area, sorry (tm Canada 🇨🇦). UPDATE 0aWe removed our comment posted in the wrong area, clarified GH-discussioncomment-11700230 and GH-discussioncomment-11700213 and hid comments that were made during the person before we did our cleanup. Sorry (tm Canada 🇨🇦) for the inconvenience. |
No worries at all. I thought it might be that but wanted to be sure I was not hallucinating or that nothing else terrible went wrong. |
I just forked (again) this repo ... cloning. Tomorrow I hope I can work on this issue and hopefully also the issue with the submit server text. I'm not sure if you replied yet. I'll have to check tomorrow as I have other things I should do now. |
I believe that I can look at the issues here next .. including maybe this one. But I have to go afk a while .. unsure if I'll get to this today but the good news is the two important issues over there should be done and some improvements to jparse error reporting was done too! |
I aim to look at this tomorrow. I believe I'm done for the day. I need to locate something in one of the discussions as I think you said I might be able to help but I will have to do that another time too. Good day! |
Okay so I know there's the delay .. sorry about this! I have been busy with the other problems. I'm not sure if I can get to this today either. It depends. I'm going to see if I can find the discussion where there was talk about subdirectories in submissions as that also seems important. If I have the time and energy I can start looking at this based on the comments I made in the discussions. |
Okay I'll have to look at this tomorrow. Been awake too long and trying to focus on the other issues has drained me of my faculties. Hopefully everything else besides the make test issue in NetBSD is resolved and then I can focus on this. And thankfully that strange issue is not affecting the ability to use the tools to submit to the contest. Not ideal and maybe it should be moved over to jparse but the most important part is the tools work. |
I have to do the bug fix in txzchk .. hoping to do that now (which really means updating the JSON files for the new version as the bug fix was done yesterday when offline). After that I'll open a pull request. But I have to open another one too for the regexp thing and for that I have to find the email from you first. I also have a slight improvement in the GitHub issue templates (it is in some but not all), just a display thing. But I must go afk soon too. I'm extremely tired today but fortunately the discussions I opened about rules and guidelines should be helpful as I noted a lot of the issues. I believe however that this issue is less important than those other issues so I'm going to push this out until I can finish those and then have the energy and faculties to work on these. When I do that I'll end up updating them for subdirectory feature I recently added. As the FAQ has changed in set up and since we have to discuss how to organise it (I left some comments on it btw, briefly), I might hold off in editing the FAQ until after that. But once the guidelines and rules discuss it (and I guess especially the rules and in particular rule 17) it'll be easier to do anyway. I hope I can return to this issue later today but that remains unclear at this time. If I can't get to it today then I hope to tomorrow morning! |
Well as you know this might be pushed out even further but we will have to see I guess. It depends on what work you have done with the mkiocccentry tool and how I feel. I know there's a comment you left in another issue about this so I will look at that but possibly not for a while. Today I should have more time but I also still have to catch up on some other things and I am feeling very tired. That part very possibly will change however. I believe that I will try getting to some of this today even if not everything is completed over there. But that doesn't mean that I will. I might just take it easy today. But that's my update on this issue .. for now. |
Working on the rules now and I have run into an issue. In particular the additional filenames. I'm not sure what to do. The maximum characters is one thing but is that (remind me please) the basename length or the full path? Perhaps we need to specify both? And as for the regexp. We discussed this but given that things have changed and are changing I am not clear what it should be. I have to leave soon but perhaps you can help clarify these details so I can maybe get more done tomorrow. Thanks! |
The path from the top of the submission. There is a maximum length of a path component (each directory and each filename), as well as an overall path length from the top. Here "top" is 'topdir', or the directory under |
Use that description where the regex was for each path component and with the text that followed .. instead of trying to be fancy and come up with a single regex for the while path. UPDATE 0aHow about using something along the lines of the text in UPDATE 0a of GH-issuecomment-2580748758? |
I am trying to parse the above but I'm too tired right now. I hope to look at it in a bit though that's more likely a fair bit later. Thanks for the replies. I did think of something though that I forgot to bring up. The error message in mkiocccentry (which I know the code there will be modified as you do the task over there though I have an update - I think - planned) only talks about the regexp but not the max depth or max length. So a new error message should be written but what it should be I don't know. When that is done it can be updated in the rule too (and I guess guidelines if it's talked about - and FAQ of course). |
I hope to reply to your comments on Thursday morning. Hopefully we will have more progress at the other repo too by then and it will help with this (and in particular rule 17). |
We believe we have addressed all of the current questions that still need answering at this time. If we've missed something or something else needs to be clarified, please ask again. |
I am hoping I can get to this tomorrow or the next day. I started again today but I can't focus unfortunately. I think I might have to not do much today yet again. Code is definitely out of the question (at least at this time). I will get to this before the contest opens though, somehow or another. Best wishes on the server today! |
Well as you know I did do an update at least but not sure about this. I'm going to try however. It's fairly windy here - living in a valley doesn't help matters - and there is another chance of a power cut. Hopefully that does not happen but if it does it is uncertain how long it'll be out because it depends on the wind. If it does happen hopefully not cut for that long. I am going to try looking at the links in the OP now and see if I can get started. I know I started out doing some of it but I'm pondering just going through all of it rather than trying to go through a list of issues. I remember you wanted help with that list of words too. I guess that is of lower priority however. If the power is cut I might add that I won't have the laptop up most likely so I won't be able to work on things offline. But hopefully that doesn't happen and hopefully Internet service stays up too. |
We believe we have addressed all of the current questions that still need answering at this time. If we've missed something or something else needs to be clarified, please ask again. |
Is there an existing issue for this?
Describe the problem
See my discussions:
I'm happy to discuss these and open pull requests to fix those that should be fixed.
Screenshots
No screenshots but the links I gave quotes to the problematic locations, notwithstanding those I omitted deliberately.
What you expect
Less ambiguity, more clarity and fewer errors ?
Relevant links
No.
Environment
Do you have JavaScript enabled?
Anything else?
Feel free to assign this to me. We can discuss the issues raised and then I can fix them. I can if you want copy and paste the message into this with a comment for each. Alternatively it might be better to open another issue and rename this one so that we can keep the rules and guidelines separate.
The text was updated successfully, but these errors were encountered: