Skip to content
This repository has been archived by the owner on Feb 23, 2021. It is now read-only.

Add support for additional Skip and Take scenarios #10

Open
sflanker opened this issue Jun 20, 2018 · 0 comments
Open

Add support for additional Skip and Take scenarios #10

sflanker opened this issue Jun 20, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@sflanker
Copy link
Member

There are a number of edge cases for Skip and Take that aren't supported:

  1. Calling Skip without subsequently calling Take
  2. Calling Skip multiple times
  3. Calling Take multiple times

It should be possible to support all of these scenarios. Multiple calls can be folded into a single call in trivial cases. In more complicated scenarios involving mixed calls to Where and Skip/Take it will be necessary to generate a subquery. A Skip without any Take can be implemented with session variables.

Test case overrides:

[Fact(Skip = "TODO: Not Supported (Skip must be combined with Take)")]
public override void Skip() {
}
[Fact(Skip = "TODO: Not Supported (Multiple Skips not supported)")]
public override void Skip_Skip() {
}
[Fact(Skip = "TODO: Not Supported (Multiple Takes not supported)")]
public override void Take_Take() {
}

@sflanker sflanker added the enhancement New feature or request label Jun 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant