From b836f9fd9cb0d6b6f50cb180ab48537360b3d84b Mon Sep 17 00:00:00 2001 From: Jasveen Date: Thu, 23 Feb 2023 20:58:15 +0530 Subject: [PATCH] Identify implicit use of enumerate method --- invesalius/gui/default_tasks.py | 4 ++-- invesalius/gui/dialogs.py | 20 ++++++++++---------- invesalius/gui/dicom_preview_panel.py | 12 ++++++------ 3 files changed, 18 insertions(+), 18 deletions(-) diff --git a/invesalius/gui/default_tasks.py b/invesalius/gui/default_tasks.py index 6c1f61787..81e8d9c62 100644 --- a/invesalius/gui/default_tasks.py +++ b/invesalius/gui/default_tasks.py @@ -256,8 +256,8 @@ def __init__(self, parent): (_("Export data"), exporter.TaskPanel), (_("Navigation system"), navigator.TaskPanel)] - for i in range(len(tasks)): - (name, panel) = tasks[i] + for i, item in enumerate(tasks): + (name, panel) = item # Create panel item = fold_panel.AddFoldPanel("%d. %s"%(i+1, name), collapsed=True, diff --git a/invesalius/gui/dialogs.py b/invesalius/gui/dialogs.py index a98850f83..7b1346d80 100644 --- a/invesalius/gui/dialogs.py +++ b/invesalius/gui/dialogs.py @@ -3827,8 +3827,8 @@ def _init_gui(self): if sys.platform != 'win32': combo_surface_name.SetWindowVariant(wx.WINDOW_VARIANT_SMALL) combo_surface_name.Bind(wx.EVT_COMBOBOX, self.OnComboName) - for n in range(len(self.proj.surface_dict)): - combo_surface_name.Insert(str(self.proj.surface_dict[n].name), n) + for n, item in enumerate(self.proj.surface_dict): + combo_surface_name.Insert(str(item.name), n) self.combo_surface_name = combo_surface_name @@ -4075,8 +4075,8 @@ def ErrorEstimation(self, surface, points): subId = mutable(0) d = mutable(0.0) error = [] - for i in range(len(points)): - cell_locator.FindClosestPoint(points[i], c, cellId, subId, d) + for i, item in enumerate(points): + cell_locator.FindClosestPoint(item, c, cellId, subId, d) error.append(np.sqrt(float(d))) return np.mean(error) @@ -4163,8 +4163,8 @@ def OnICP(self, evt): sourcePoints = np.array(self.point_coord) sourcePoints_vtk = vtkPoints() - for i in range(len(sourcePoints)): - id0 = sourcePoints_vtk.InsertNextPoint(sourcePoints[i]) + for i, item in enumerate(sourcePoints): + id0 = sourcePoints_vtk.InsertNextPoint(item) source = vtkPolyData() source.SetPoints(sourcePoints_vtk) @@ -4323,8 +4323,8 @@ def _init_gui(self): if sys.platform != 'win32': combo_surface_name.SetWindowVariant(wx.WINDOW_VARIANT_SMALL) combo_surface_name.Bind(wx.EVT_COMBOBOX, self.OnComboNameScalpSurface) - for n in range(len(self.proj.surface_dict)): - combo_surface_name.Insert(str(self.proj.surface_dict[n].name), n) + for n, item in enumerate(self.proj.surface_dict): + combo_surface_name.Insert(str(item.name), n) txt_brain_surface = wx.StaticText(self, -1, _('Select the brain surface:')) @@ -4334,8 +4334,8 @@ def _init_gui(self): if sys.platform != 'win32': combo_brain_surface_name.SetWindowVariant(wx.WINDOW_VARIANT_SMALL) combo_brain_surface_name.Bind(wx.EVT_COMBOBOX, self.OnComboNameBrainSurface) - for n in range(len(self.proj.surface_dict)): - combo_brain_surface_name.Insert(str(self.proj.surface_dict[n].name), n) + for n, item in enumerate(self.proj.surface_dict): + combo_brain_surface_name.Insert(str(item.name), n) init_surface = 0 combo_surface_name.SetSelection(init_surface) diff --git a/invesalius/gui/dicom_preview_panel.py b/invesalius/gui/dicom_preview_panel.py index a5f234ea7..73d8305b0 100644 --- a/invesalius/gui/dicom_preview_panel.py +++ b/invesalius/gui/dicom_preview_panel.py @@ -657,12 +657,12 @@ def OnPreviewClick(self, evt): self.first_selection = dicom_id self.last_selection = dicom_id - for i in range(len(self.files)): + for i, item in enumerate(self.files): if i == dicom_id: - self.files[i].selected = True + item.selected = True else: - self.files[i].selected = False + item.selected = False my_evt = SerieEvent(myEVT_CLICK_SLICE, self.GetId()) @@ -675,11 +675,11 @@ def OnPreviewClick(self, evt): self.selected_panel.select_on = self.selected_panel is evt.GetEventObject() if self.first_selection != self.last_selection: - for i in range(len(self.files)): + for i, item in enumerate(self.files): if i >= self.first_selection and i <= self.last_selection: - self.files[i].selected = True + item.selected = True else: - self.files[i].selected = False + item.selected = False else: self.selected_panel.Select()