Skip to content

Commit c2b6788

Browse files
committed
ui: fix remove reviewer + UI fixes
1 parent faa99c9 commit c2b6788

File tree

2 files changed

+15
-15
lines changed

2 files changed

+15
-15
lines changed

.python-version

Lines changed: 0 additions & 1 deletion
This file was deleted.

invenio_requests/assets/semantic-ui/js/invenio_requests/request/RequestReviewers.js

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,16 @@ const CollapsedHeader = ({ canReview, onOpen, label }) => {
4444
);
4545
}
4646
return (
47-
<Header as="h3" size="tiny" onClick={onOpen} className="cursor-pointer">
48-
{label}
49-
<Icon name="setting" className="right-floated" size="mini" />
50-
</Header>
47+
<Grid onClick={onOpen} className="pb-0">
48+
<Grid.Column width={12}>
49+
<Header as="h3" size="tiny" className="m-0">
50+
{label}
51+
</Header>
52+
</Grid.Column>
53+
<Grid.Column width={4}>
54+
<Icon name="setting" />
55+
</Grid.Column>
56+
</Grid>
5157
);
5258
};
5359

@@ -121,10 +127,10 @@ const SelectedReviewersList = ({ selectedReviewers, removeReviewer, i18next }) =
121127
{i18next.t("Selected reviewers")}
122128
</Header>
123129

124-
<Grid>
130+
<Grid className="pt-10 mb-5">
125131
{selectedReviewers.map((reviewer) => (
126132
<>
127-
<Grid.Column width={14} className="pb-0">
133+
<Grid.Column width={13} className="pb-0">
128134
<React.Fragment key={reviewer.id}>
129135
{isResourceDeleted(reviewer) ? (
130136
<DeletedResource details={reviewer} />
@@ -136,7 +142,7 @@ const SelectedReviewersList = ({ selectedReviewers, removeReviewer, i18next }) =
136142
</React.Fragment>
137143
</Grid.Column>
138144
<Grid.Column width={2}>
139-
<Icon name="close" className="right-floated" />
145+
<Icon name="close" className="right-floated" onClick={() => removeReviewer(reviewer.id)} />
140146
</Grid.Column>
141147
</>
142148
))}
@@ -228,7 +234,7 @@ export const RequestReviewers = ({ request, permissions }) => {
228234
label={i18next.t("Reviewers")}
229235
/>
230236
{!isMenuOpen ? (
231-
<Grid>
237+
<Grid className="mt-0">
232238
{selectedReviewers.map((reviewer) => (
233239
<>
234240
<Grid.Column width={14} className="pb-0">
@@ -242,16 +248,11 @@ export const RequestReviewers = ({ request, permissions }) => {
242248
)}
243249
</React.Fragment>
244250
</Grid.Column>
245-
{request.last_opiniated_reviews?.user == reviewer.id && (
246-
<Grid.Column width={2}>
247-
<Icon name="green check" className="right-floated" />
248-
</Grid.Column>
249-
)}
250251
</>
251252
))}
252253
</Grid>
253254
) : (
254-
<Segment attached>
255+
<Segment>
255256
<ReviewerSearch
256257
searchType={searchType}
257258
onFilterChange={setSearchType}

0 commit comments

Comments
 (0)