chore: cleanup

Author: yashlamba

invenio_requests/assets/semantic-ui/js/invenio_requests/api/InvenioRequestApi.js

@@ -5,7 +5,6 @@
 // under the terms of the MIT License; see LICENSE file for more details.
 
 import _isEmpty from "lodash/isEmpty";
-import _toNumber from "lodash/toNumber";
 import { http } from "react-invenio-forms";
 
 export class RequestLinksExtractor {

invenio_requests/customizations/request_types.py

@@ -185,12 +185,6 @@ def _create_marshmallow_schema(cls):
                 RefBaseSchema.create_from_dict(cls.allowed_receiver_ref_types),
                 allow_none=cls.receiver_can_be_none,
             ),
-            "last_opiniated_reviews": ma.fields.Dict(
-                user=ma.fields.String(),
-                state=ma.fields.String(),
-                timestamp=ma.fields.DateTime(),
-                allow_none=True,
-            ),
             "reviewers": ma.fields.List(
                 ma.fields.Nested(
                     MultipleEntityReferenceBaseSchema.create_from_dict(

invenio_requests/services/requests/params.py

@@ -98,7 +98,6 @@ def _generate_my_requests_query(self, identity):
             should=[
                 dsl.Q("term", **{created_by: identity.id}),
                 dsl.Q("term", **{receiver: identity.id}),
-                dsl.Q("term", **{receiver: identity.id}),
             ],
         )
 

invenio_requests/services/results.py

@@ -7,6 +7,7 @@
 
 """Request service results."""
 
+from invenio_access.permissions import system_user_id
 from invenio_records_resources.services.records.results import ExpandableField
 
 from ..resolvers.registry import ResolverRegistry
@@ -92,7 +93,7 @@ def add_dereferenced_record(self, service, value, resolved_rec):
         """Save the dereferenced record."""
         # mark the record as a "ghost" or "system" record i.e not resolvable
         if resolved_rec is None:
-            if value == "1":
+            if value == system_user_id:
                 resolved_rec = self.system_record()
             else:
                 resolver_type = self._get_resolver_type(service)