-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.nx/
makes all-contributors plugin think info has changed, crashes pipeline
#2457
Comments
Yes, same issue here. Thanks for the tip regarding the |
The most likely candidate is that it's coming from Lernas dependencies.
I think this is probably the best course of action all round as that directory is considered temporary for containing local cache data for nx. Another option would be to try setting the lerna.json property |
Describe the bug
I am unable to find any mentions of
nx
in this repo (the private repo this is failing on doesn't usenx
), but for some reason, a.nx/
folder is being added when I useyarn auto shipit -vv
on ourmaster
branch, which runs the all-contributors plugin. As far as I can tell, it's not coming from our end, because we don't usenx
AND we rungit reset --hard
right before callingauto
.Re: this discussion, when working with
nx
>= 17, the.nx/
folder has been moved fromnode_modules/.cache
to the workspace root. This is causingchangedFiles
in the code below to be true, which makes the plugin think that the README and .all-contributorsrc have been updated. The plugin tries to commit these files and errors out because those files actually have not changed.auto/plugins/all-contributors/src/index.ts
Lines 360 to 366 in 335fadb
Here is the error shown with `-vv`
To Reproduce
I will try to reproduce this with a small repo. TBD.
Expected behavior
I expect
auto
to:shipit
is called onmaster
Environment information:
Additional Context
.nx/
to our.gitignore
..nx/
in the repo this issue was discovered on, so not sure where it's coming frommaster
but not for other branches. I didn't testnext
The text was updated successfully, but these errors were encountered: