Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-isfs virtual workspaces for client-side editing #1278

Open
isc-bsaviano opened this issue Dec 6, 2023 · 1 comment
Open

Support non-isfs virtual workspaces for client-side editing #1278

isc-bsaviano opened this issue Dec 6, 2023 · 1 comment

Comments

@isc-bsaviano
Copy link
Contributor

There are a bunch of places in our code where we check the scheme of a URI and use "file" to mean client-side editing. We should consider supporting any scheme other than isfs and isfs-readonly for client-side editing.

cc @gjsjohnmurray for comment

Original issue: intersystems/language-server#294

@isc-bsaviano
Copy link
Contributor Author

I took a look at this and it's pretty complicated. To support this, we'd need to make our code that generates a URI for a document async. That code is used in a lot of places, including our exported API, which makes such a change very invasive. I'm not sure this is worth doing unless we also re-evaluate how we generate URIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant