Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info if sending Root CA #1537

Open
bwbroersma opened this issue Oct 30, 2024 · 0 comments
Open

Info if sending Root CA #1537

bwbroersma opened this issue Oct 30, 2024 · 0 comments
Milestone

Comments

@bwbroersma
Copy link
Collaborator

Sending the Root CA in the ServerHello is not needed, other tools like SSL Labs will have a orange ⚠️ "Contains anchor" and show "Sent by server" in combination with "In trust store" for the Root CA.

The current code has a notion of Root CA's, e.g. see:

for cert in self.chain:
# Only validate signarture of non-root certificates
if not is_root_cert(cert):

Proposal is to give an ℹ️ info if sending Root CA's.

@bwbroersma bwbroersma added this to the intake milestone Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant