Skip to content

Commit a8fe987

Browse files
committed
fix cert name display
1 parent 28d6e76 commit a8fe987

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

checks/tasks/tls/scans.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -332,13 +332,8 @@ def cert_checks(hostname, mode, task, af_ip_pair=None, dane_cb_data=None, *args,
332332

333333
# Extract all names from a certificate, taken from sslyze' _cert_chain_analyzer.py
334334
subj_alt_name_ext = parse_subject_alternative_name_extension(leaf_cert)
335-
subj_alt_name_as_list = [("DNS", name) for name in subj_alt_name_ext.dns_names]
336-
subj_alt_name_as_list.extend([("IP Address", ip) for ip in subj_alt_name_ext.ip_addresses])
337-
certificate_names = {
338-
"subject": (tuple([("commonName", name) for name in get_common_names(leaf_cert.subject)]),),
339-
"subjectAltName": tuple(subj_alt_name_as_list),
340-
}
341-
hostmatch_bad = certificate_names
335+
certificate_names = set(get_common_names(leaf_cert.subject) + subj_alt_name_ext.dns_names + subj_alt_name_ext.ip_addresses)
336+
hostmatch_bad = ", ".join(certificate_names)
342337

343338
trusted_score = (
344339
trusted_score_good

0 commit comments

Comments
 (0)