diff --git a/checks/tasks/tls/evaluation.py b/checks/tasks/tls/evaluation.py index b7b6f6742..cd500fa16 100644 --- a/checks/tasks/tls/evaluation.py +++ b/checks/tasks/tls/evaluation.py @@ -200,4 +200,3 @@ def _unique_unhashable(ciphers: List[Any]) -> List[Any]: if cipher not in result: result.append(cipher) return result - diff --git a/checks/tasks/tls/scans.py b/checks/tasks/tls/scans.py index cdad3f685..bae5bcd2c 100644 --- a/checks/tasks/tls/scans.py +++ b/checks/tasks/tls/scans.py @@ -332,8 +332,10 @@ def cert_checks(hostname, mode, task, af_ip_pair=None, dane_cb_data=None, *args, # Extract all names from a certificate, taken from sslyze' _cert_chain_analyzer.py subj_alt_name_ext = parse_subject_alternative_name_extension(leaf_cert) - certificate_names = set(get_common_names(leaf_cert.subject) + subj_alt_name_ext.dns_names + subj_alt_name_ext.ip_addresses) - hostmatch_bad = ", ".join(certificate_names) + certificate_names = set( + get_common_names(leaf_cert.subject) + subj_alt_name_ext.dns_names + subj_alt_name_ext.ip_addresses + ) + hostmatch_bad = certificate_names trusted_score = ( trusted_score_good