Skip to content

Update AS spec to ensure correct limits during outgoing payment grant creation #3337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks
mkurapov opened this issue Mar 7, 2025 · 0 comments · May be fixed by #3429
Open
2 tasks

Update AS spec to ensure correct limits during outgoing payment grant creation #3337

mkurapov opened this issue Mar 7, 2025 · 0 comments · May be fixed by #3429
Assignees

Comments

@mkurapov
Copy link
Contributor

mkurapov commented Mar 7, 2025

Context

Currently, when we create an outgoing payment grant request, we can pass in a limits attribute with debitAmount and/or receiveAmount. For simplicity of the API as well as the simplicity of documenting how these amounts are used, we should update the spec to allow only setting limits.debitAmount OR limits.receiveAmount, not both.

When this change lands, we need to update the open-payments client in the AS to make sure we are correctly validating the incoming request.

Todos

  • Update open-payments client in AS after issue above is finished
  • Add run time check in the AS during grant creation to make sure that both receiveAmount and debitAmount aren't present in the limits
@github-project-automation github-project-automation bot moved this to Backlog in Rafiki Mar 7, 2025
@mkurapov mkurapov moved this from Backlog to In Progress in Rafiki Mar 18, 2025
@mkurapov mkurapov moved this from In Progress to Todo in Rafiki Mar 18, 2025
@oana-lolea oana-lolea moved this from Todo to In Progress in Rafiki Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants