Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watchman should not be downloaded in CI or production images #2261

Open
mlodic opened this issue Apr 12, 2024 · 2 comments
Open

Watchman should not be downloaded in CI or production images #2261

mlodic opened this issue Apr 12, 2024 · 2 comments

Comments

@mlodic
Copy link
Member

mlodic commented Apr 12, 2024

this should be downloaded only for local development

@geckiss
Copy link

geckiss commented May 14, 2024

Hello, not sure if this is correct issue but the default value of $WATCHMAN envar in Dockerfile is set incorrectly. It is set to false, however, watchman install script requires False, with capital F, to not install Watchman.

If you try to rebuild the image from repository, you can see Saving to: ‘watchman-v2024.02.12.00-linux.zip’ in output logs. However, if you set $WATCHMAN="False", you will see Skipping WATCHMAN installation because we are not in test mode.

@mlodic
Copy link
Member Author

mlodic commented May 14, 2024

hey @geckiss thank you very much for your help. I think we are pretty bad with typos and so on 🤣 so please could you open a very little PR request to show the exact change that you have done? In this way we can understand it better and you can also get credit for your contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants