Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from ReadTheDocs to Mkdocs by leveraging Github Pages #2043

Open
mlodic opened this issue Dec 27, 2023 · 12 comments
Open

Move from ReadTheDocs to Mkdocs by leveraging Github Pages #2043

mlodic opened this issue Dec 27, 2023 · 12 comments

Comments

@mlodic
Copy link
Member

mlodic commented Dec 27, 2023

Mkdocs reference: https://github.com/mkdocs/mkdocs

We could host the site via Github Pages. See how OpenCTI does it here: https://docs.opencti.io/. They use this style

In this way we would have a centralized place for documentation and we can change it without the need to make a release in the Project itself.

All the documentation regarding the list of plugins name can be kept inside this repo to avoid to have the contributors that create a new analyzer to update 2 repos at once.

@mlodic
Copy link
Member Author

mlodic commented Dec 29, 2023

This would also solve other problems we have with ReadTheDocs for the GreedyBear project which would need to be included in that new documentation too

@mlodic
Copy link
Member Author

mlodic commented Dec 29, 2023

It could be helpful to follow this guide.

I would remove completely the ReDoc API documentation and the related code (see add_docs and drf_spectacular) and leverage a new way to document the APIs that is less impactful and more easier supported.

It is also important to add a section dedicated to PyIntelOwl in the new documentation. Move/deprecate what there is about the PyIntelOwl documentation here. Then leverage docstrings or whatever to build the new documentation for the PyIntelOwl library

@g4ze
Copy link
Contributor

g4ze commented Jan 5, 2024

Hey @mlodic I read the guide you provided. It seems evident that the features of mkdocs can be leveraged by writing code with docstring comments. This in-turn would keep the docs updated and save us extra hassle. I'm curious and please correct me here if I'm wrong; to migrate to mkdocs, wouldn't we have to make sure that our already existing codebase is rewritten well with docstrings??

@mlodic
Copy link
Member Author

mlodic commented Jan 5, 2024

I guess so

@shivam-sharma7
Copy link

@mlodic I will look into this. Would you like to share steps in short?

@dextrot
Copy link

dextrot commented Feb 17, 2024

@mlodic I've experience working with MkDocs and have contributed to projects who have their documentation based on MkDocs.

@aryan-bhokare
Copy link
Contributor

aryan-bhokare commented Feb 28, 2024

Hey @mlodic I read the guide you provided. It seems evident that the features of mkdocs can be leveraged by writing code with docstring comments. This in-turn would keep the docs updated and save us extra hassle. I'm curious and please correct me here if I'm wrong; to migrate to mkdocs, wouldn't we have to make sure that our already existing codebase is rewritten well with docstrings??

We may have to modify and add the docstring to the codebase little by little.
What do you think @mlodic.

@PranithChowdary
Copy link

Docusaurus reference link: https://github.com/facebook/docusaurus

@mlodic, can we use Docusaurus by Meta for this documentation ! Seems like a good fit for our docs. Centralized location, easier updates, and less work for contributors. We should discuss integration and maintenance before deciding.

@mlodic
Copy link
Member Author

mlodic commented Mar 7, 2024

Docusaurus is a cool project but I'd like to understand the advantages that we would have if we compare it with MkDocs. I would like to prioritize something simple and easy to be used. We don't need particular advanced features

@shivam-sharma7
Copy link

@mlodic docsify is also good check once https://docsify.js.org/#/?id=docsify

@rabbabansh
Copy link

rabbabansh commented Mar 9, 2024

@mlodic I think Docusaurus is a good fit for this particular use-case. Can you assign it to me so I can start working on it?

@tarunsinghofficial
Copy link

@mlodic The MkDocs is a good fit for migrating all existing docs to it. We can easily migrate all docs easily. Let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants