Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

media-driver 18.3.0 - compilation fails on 32bit #356

Closed
kwizart opened this issue Oct 11, 2018 · 10 comments
Closed

media-driver 18.3.0 - compilation fails on 32bit #356

kwizart opened this issue Oct 11, 2018 · 10 comments
Assignees
@XinfengZhang
Labels
P3 Low priority no customer usage, no business requirements, not from communities, just from internal Reserved Information to describe some implementation detail or restriction Won't Fix Issue: won't support platform/feature/request

Comments

@kwizart
Copy link

kwizart commented Oct 11, 2018 •
edited
Loading

I'm trying to compile on media-driver 18.0.3 on i686 and I have a compilation error.
For the record, I still consider important to have a 32bit for running steam client on x86_64 OS.

Full compilation log: http://koji.rpmfusion.org/kojifiles/work/tasks/6969/266969/build.log

cc1 -m32 -march=i686 -mtune=generic -msse2 -mfpmath=sse -mstackrealign -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -Wno-reorder -Wsign-promo -Wnon-virtual-dtor -Wno-invalid-offsetof -fvisibility-inlines-hidden -fno-use-cxa-atexit -frtti -fexceptions -fpermissive -fcheck-new -std=c++1y -std=c++11 -DNDEBUG -fPIC   -Werror -Wall -Winit-self -Wpointer-arith -Wno-unused -Wno-unknown-pragmas -Wno-comments -Wno-sign-compare -Wno-attributes -Wno-narrowing -Wno-overflow -Wno-parentheses -Werror=implicit-function-declaration -Werror=address -Werror=format-security -Werror=non-virtual-dtor -Werror=return-type -march=corei7 -mpopcnt -msse -msse2 -msse3 -mssse3 -msse4.1 -msse4.2 -msse4 -mfpmath=sse -finline-functions -fno-short-enums -Wa,--noexecstack -fno-strict-aliasing -DUSE_MMX -DUSE_SSE -DUSE_SSE2 -DUSE_SSE3 -DUSE_SSSE3 -fmessage-length=0 -fstack-protector -fdata-sections -ffunction-sections -m32 -DLINUX=1 -DLINUX -DNO_RTTI -DNO_EXCEPTION_HANDLING -DINTEL_NOT_PUBLIC -g -fvisibility=hidden -funswitch-loops -Wl,--gc-sections -D__linux__ -fPIC -fno-tree-pre -Wl,--no-as-needed -O2 -D_FORTIFY_SOURCE=2 -fno-omit-frame-pointer -finline-limit=100 -o CMakeFiles/iHD_drv_video_OBJ.dir/agnostic/common/cm/cm_buffer_rt.cpp.o -c /builddir/build/BUILD/media-driver-intel-media-18.3.0/media_driver/agnostic/common/cm/cm_buffer_rt.cpp
make[2]: Leaving directory '/builddir/build/BUILD/media-driver-intel-media-18.3.0/build'
In file included from /builddir/build/BUILD/media-driver-intel-media-18.3.0/media_driver/linux/common/os/libdrm/include/xf86drm.h:41,
                 from /builddir/build/BUILD/media-driver-intel-media-18.3.0/media_driver/linux/common/ddi/media_libva_common.h:33,
                 from /builddir/build/BUILD/media-driver-intel-media-18.3.0/media_driver/linux/common/cm/media_libva_cm.h:30,
                 from /builddir/build/BUILD/media-driver-intel-media-18.3.0/media_driver/linux/common/cm/cm_def_os.h:41,
                 from /builddir/build/BUILD/media-driver-intel-media-18.3.0/media_driver/agnostic/common/cm/cm_def.h:30,
                 from /builddir/build/BUILD/media-driver-intel-media-18.3.0/media_driver/agnostic/common/cm/cm_buffer.h:30,
                 from /builddir/build/BUILD/media-driver-intel-media-18.3.0/media_driver/agnostic/common/cm/cm_buffer_rt.h:30,
                 from /builddir/build/BUILD/media-driver-intel-media-18.3.0/media_driver/agnostic/common/cm/cm_buffer_rt.cpp:27:
/builddir/build/BUILD/media-driver-intel-media-18.3.0/media_driver/linux/common/os/libdrm/include/libdrm_macros.h: In function 'int drm_munmap(void*, size_t)':
/builddir/build/BUILD/media-driver-intel-media-18.3.0/media_driver/linux/common/os/libdrm/include/libdrm_macros.h:40:40: error: size of array is negative
       (void) sizeof(char [1 - 2*!(COND)]); \
                                        ^
/builddir/build/BUILD/media-driver-intel-media-18.3.0/media_driver/linux/common/os/libdrm/include/libdrm_macros.h:76:4: note: in expansion of macro 'STATIC_ASSERT'
    STATIC_ASSERT(LARGE_OFF_T % 2147483629 == 721 &&
    ^~~~~~~~~~~~~
make[2]: *** [media_driver/CMakeFiles/iHD_drv_video_OBJ.dir/build.make:79: media_driver/CMakeFiles/iHD_drv_video_OBJ.dir/agnostic/common/cm/cm_buffer_rt.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:245: media_driver/CMakeFiles/iHD_drv_video_OBJ.dir/all] Error 2
make: *** [Makefile:155: all] Error 2
@kwizart kwizart changed the title media-driver 18.0.3 - compilation fails on 32bit media-driver 18.3.0 - compilation fails on 32bit Oct 11, 2018
@dvrogozh
Copy link
Contributor

Interesting that Debian did not meet with this issue and managed to package media-driver in both 32- and 64-bit flavors. They applied a custom patch however: https://salsa.debian.org/multimedia-team/intel-media-driver/blob/master/debian/patches/0002-Remove-settings-based-on-ARCH.patch, but I don't think that it relates to the issue you describe.

I had no chance to try build myself yet for Fedora/CentOS, but thought it worths to provide the above info right away.

@dvrogozh
Copy link
Contributor

@kwizart: you could wish to join discussion here: intel/libva#281

@jbeich
Copy link

jbeich commented Apr 10, 2019

Also doesn't affect FreeBSD i386 where off_t is always 64-bit.
http://beefy5.nyi.freebsd.org/data/latest-per-pkg/libva-intel-media-driver/

@th0ma7 th0ma7 mentioned this issue Jan 3, 2020
Merged
3 tasks
@XinfengZhang
Copy link
Contributor

@kwizart how about the status, (void) sizeof(char [1 - 2*!(COND)]) should be possible negative both on 32 and 64 bit, the build check option is different?

@kwizart
Copy link
Author

kwizart commented Mar 9, 2020 •
edited
Loading

@XinfengZhang I don't know why it fails only on 32bit and not on 64bit.

I've resubmitted a build and have hit the same build error.
You can have a look using the build.log:
http://koji.rpmfusion.org/koji/taskinfo?taskID=392623

@dvrogozh
Copy link
Contributor

dvrogozh commented Mar 9, 2020

@kwizart : the code (starting from)

media-driver/media_driver/linux/common/os/i915/include/libdrm_macros.h

Line 68 in 60c0a69

# define drm_mmap(addr, length, prot, flags, fd, offset) \
which fails to compile on your side is still a copy from https://gitlab.freedesktop.org/mesa/drm/-/blob/master/libdrm_macros.h#L70. So, I wonder, does libdrm still can be successfully compiled on 32-bit Fedora? And if yes, why? It seems the static assert check tries to verify that off_t is 64-bit and it fails... What's sizeof(off_t) on Fedora 32-bit? Are there any compilation flags required to fetch correct off_t defition?

@kwizart
Copy link
Author

kwizart commented Mar 9, 2020

It's interesting that there is mention of LARGE FILE support and on linux x86 32bit there is indeed a need to enable a special CXXFLAGS such as -D_FILE_OFFSET_BITS=64 or by default the value is 32.

I confirm that now that this define is set I have a different error (probably unrelated as it might also have failed on x86_64) (1)

I've checked with fedora libdrm, and this flag isn't set explicitly in the package, so it might be autodetected as appropriate. But for the libva case, I don't see this flag been set, so I might have to enforce it. (and even maybe to all downstream users of the vaapi strack ?).

(1)

make[2]: Leaving directory '/builddir/build/BUILD/media-driver-intel-media-19.4.0/build'
/builddir/build/BUILD/media-driver-intel-media-19.4.0/media_driver/linux/common/os/i915/xf86drm.c: In function 'int drmOpenByBusid(const char*, int)':
/builddir/build/BUILD/media-driver-intel-media-19.4.0/media_driver/linux/common/os/i915/xf86drm.c:606:15: error: '%s' directive argument is null [-Werror=format-overflow=]
606 | drmMsg("drmOpenByBusid: drmGetBusid reports %s\n", buf);
| ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors

@dvrogozh
Copy link
Contributor

dvrogozh commented Mar 9, 2020

I've checked with fedora libdrm, and this flag isn't set explicitly in the package

I also don't see it's set explicitly. Though I always though that's the flag which needs explicit setting. Maybe there is some special meson setting which triggers it's being set implicitly and we miss it in a grep. Anyway, I think it worth to be added permanently to the driver build flags.

Yeah, the second issue looks unrelated.

@XinfengZhang XinfengZhang added P3 Low priority no customer usage, no business requirements, not from communities, just from internal Won't Fix Issue: won't support platform/feature/request labels May 14, 2020
@XinfengZhang XinfengZhang mentioned this issue May 26, 2020
Closed
@XinfengZhang XinfengZhang added the Reserved Information to describe some implementation detail or restriction label Jun 30, 2020
@SuperSandro2000 SuperSandro2000 mentioned this issue Oct 4, 2021
Closed
@kwizart
Copy link
Author

kwizart commented Oct 24, 2022

Compilation has succeeded with current intel-media-driver releases with -D_FILE_OFFSET_BITS=64 explicitly set.

I haven't verified if it's set by default nowadays....

@kwizart
Copy link
Author

kwizart commented Nov 29, 2022

CLosing the issue

@kwizart kwizart closed this as completed Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@XinfengZhang XinfengZhang

Labels
P3 Low priority no customer usage, no business requirements, not from communities, just from internal Reserved Information to describe some implementation detail or restriction Won't Fix Issue: won't support platform/feature/request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kwizart @dvrogozh @jbeich @XinfengZhang