Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] ProgramManager::m_EliminatedKernelArgMasks is not protected by a mutex #16836

Open
jopperm opened this issue Jan 30, 2025 · 0 comments
Open

Comments

@jopperm
Copy link
Contributor

jopperm commented Jan 30, 2025

In contrast to other, similar members in the ProgramManager class, accesses to the m_EliminatedKernelArgMasks map are not protected by a mutex (e.g. [1], [2]). The code documentation does not explain whether this is intentional. We should investigate whether a mutex is needed, and either update the documentation, use the existing m_BuiltInKernelIDsMutex like most of the other members, or introduce a new mutex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant