Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic/fpga_tests/fpga_pipes.cpp fails in post-commit #16693

Open
KornevNikita opened this issue Jan 20, 2025 · 5 comments · May be fixed by #16796
Open

Basic/fpga_tests/fpga_pipes.cpp fails in post-commit #16693

KornevNikita opened this issue Jan 20, 2025 · 5 comments · May be fixed by #16796
Labels
bug Something isn't working

Comments

@KornevNikita
Copy link
Contributor

Describe the bug

e2e-lin (Intel GEN12 Graphics with Level Zero, ["Linux", "gen12"], level_zero:gpu;opencl:fpga, true) / Intel GEN12 Graphics with Level Zero

******************** TEST 'SYCL :: Basic/fpga_tests/fpga_pipes.cpp' FAILED ********************
Exit Code: 255

Command Output (stdout):
--
# RUN: at line 6
/__w/llvm/llvm/toolchain/bin//clang++  -Werror -fsycl -fsycl-targets=spir64  /__w/llvm/llvm/llvm/sycl/test-e2e/Basic/fpga_tests/fpga_pipes.cpp -o /__w/llvm/llvm/build-e2e/Basic/fpga_tests/Output/fpga_pipes.cpp.tmp.out
# executed command: /__w/llvm/llvm/toolchain/bin//clang++ -Werror -fsycl -fsycl-targets=spir64 /__w/llvm/llvm/llvm/sycl/test-e2e/Basic/fpga_tests/fpga_pipes.cpp -o /__w/llvm/llvm/build-e2e/Basic/fpga_tests/Output/fpga_pipes.cpp.tmp.out
# note: command had no output on stdout or stderr
# RUN: at line 7
env ONEAPI_DEVICE_SELECTOR=opencl:fpga  /__w/llvm/llvm/build-e2e/Basic/fpga_tests/Output/fpga_pipes.cpp.tmp.out
# executed command: env ONEAPI_DEVICE_SELECTOR=opencl:fpga /__w/llvm/llvm/build-e2e/Basic/fpga_tests/Output/fpga_pipes.cpp.tmp.out
# .---command stderr------------
# | DEBUG: executing test 1
# | DEBUG: executing test 2
# | DEBUG: executing test 3
# | DEBUG: executing test 4
# | DEBUG: executing test 5
# | DEBUG: executing test 6
# | DEBUG: executing test 7
# | DEBUG: executing test 8
# | DEBUG: executing test 9
# | DEBUG: executing test 10
# | DEBUG: executing test 11
# | DEBUG: executing test 12
# | DEBUG: Finished with result -1
# `-----------------------------
# error: command failed with exit status: 2[55](https://github.com/intel/llvm/actions/runs/12868856344/job/35879918377?pr=16671#step:24:56)

To reproduce

  1. Include a code snippet that is as short as possible
  2. Specify the command which should be used to compile the program
  3. Specify the command which should be used to launch the program
  4. Indicate what is wrong and what was expected

Environment

  • OS: [e.g Windows/Linux]
  • Target device and vendor: [e.g. Intel GPU]
  • DPC++ version: [e.g. commit hash or output of clang++ --version]
  • Dependencies version: [e.g. the output of sycl-ls --verbose]

Additional context

No response

@cperkinsintel
Copy link
Contributor

This fpga_pipe.cpp test has been passing because it was using the wrong binary operation to fold together test results. I fixed this in this and some other tests recently. My PR passed the CI because, apparently, we don't have exercise the FPGA accelerator (or emulator) there.

fpga_pipe.cpp tests 12 different combinations, the last two ( test_array_th_nb_pipe and test_array_th_bl_pipe ) are failing. Rather than disable the entire test, I'm going to just disable those two and open a ticket for them.

steffenlarsen pushed a commit that referenced this issue Jan 21, 2025
to address post-commit failure here:
#16693


This fpga_pipe.cpp test has been passing because it was using the wrong
binary operation to fold together test results. I fixed this in this and
some other tests recently. My PR passed the CI because, apparently, we
don't have exercise the FPGA accelerator (or emulator) there.

fpga_pipe.cpp tests 12 different combinations, the last two (
`test_array_th_nb_pipe` and `test_array_th_bl_pipe` ) are failing.
Opening a JIRA.
@cperkinsintel
Copy link
Contributor

@KornevNikita - The PR that disables the two failing cases has been merged and a JIRA opened for them. This test should be passing in post-commit testing now. Is it OK to close this GitHub issue?

@KornevNikita
Copy link
Contributor Author

@cperkinsintel I don't mind, but I guess this should contain jira number rather than link to this issue.

@aelovikov-intel
Copy link
Contributor

@cperkinsintel I don't mind, but I guess this should contain jira number rather than link to this issue.

GH issues are preferrable as everybody has access to them.

@KornevNikita
Copy link
Contributor Author

GH issues are preferrable as everybody has access to them.

Agree, but it would be strange to link the closed issue. I assume it normally means the root cause was fixed. I guess we should have a jira number with some comment at least here, or just let it be opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants