-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add platform auto-detection for i965 and iHD drivers #280
Comments
Hey there, This sounds like a precedent for nondeterministic behavior. Edge cases wherein an undesired driver is auto-selected for platforms such as engineering samples and uncommon vendor IDs (such as Intel's Kabylake-G that do not conform to nominal VAAPI device creation, see this ticket in FFmpeg for an example). An ideal situation would be to allow for the instantiation of every VAAPI session with a driver name per node, as this patch-set does. Mucking around with automatic driver detection in libva will only expose a greater maintenance burden downstream over time as more devices are introduced. Rather than allow that to be the case, let the user land applications, such as ffmpeg, libav, etc govern the creation of driver-specific VAAPI instances as needed: |
An update: All these patches have been committed. |
This functionality is probably going to be necessary long-term, as the i965 driver will apparently not receive support for newer hardware, so the current autodetection code (which always picks i965 and never iHD) will need some kind of change. |
I agree, the current situation doesn't lean towards installing the newer driver. |
Actually, I tink this is fixed by following commit: 09c8c2e |
i965 and iHD drivers intersect for some platforms they can support. It worth adding auto-detection of the platform to avoid manually set LIBVA_DRIVER_NAME. Options:
We need to count situation when both drivers will be installed.
The text was updated successfully, but these errors were encountered: