From d22bfd0da76bfdeb8616b50fab2630b2c158818e Mon Sep 17 00:00:00 2001 From: Carl Zhang Date: Wed, 20 Sep 2023 09:45:38 -0400 Subject: [PATCH] va: correct the description of segment id map buffer for vp9e previous description limited the segment id block 8x8 it is not accurate and should support different block size which could be set by picture parameter. attention: this change will impact backward compatiblility, considering no one is using it. we could ignore this side effect Signed-off-by: Carl Zhang --- va/va_enc_vp9.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/va/va_enc_vp9.h b/va/va_enc_vp9.h index 83caced31..4e4ac1d8b 100644 --- a/va/va_enc_vp9.h +++ b/va/va_enc_vp9.h @@ -595,8 +595,10 @@ typedef struct _VAEncMiscParameterTypeVP9PerSegmantParam { * \brief VP9 Block Segmentation ID Buffer * * The application provides a buffer of VAEncMacroblockMapBufferType containing - * the initial segmentation id for each 8x8 block, one byte each, in raster scan order. - * Rate control may reassign it. For example, a 640x480 video, the buffer has 4800 entries. + * the initial segmentation id for each block, block size is specified by seg_id_block_size + * in VAEncPictureParameterBufferVP9 , one byte each, in raster scan order. + * Rate control may reassign it. For example, a 640x480 video, set_id_block_size is + * VA_SEGID_BLOCK_16X16 , the buffer has 1200 entries. * The value of each entry should be in the range [0..7], inclusive. * If segmentation is not enabled, the application does not need to provide it. */