New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge duplicate logic of NoSuchProcess detection #136

Open

Jongy opened this issue Apr 2, 2023 · 0 comments

Contributor

Jongy commented Apr 2, 2023

We have 2 different implementations that detect a "NoSuchProcess" state when reading ELF files of processes - https://github.com/Granulate/granulate-utils/blob/ddd5f79b2b7683af431c5b592f548fe6eff38c28/granulate_utils/linux/elf.py#L24 and https://github.com/Granulate/granulate-utils/blob/ddd5f79b2b7683af431c5b592f548fe6eff38c28/granulate_utils/linux/process.py#L122.

Personally I prefer the latter, and it seems more complete. Let's remove either and fix all sites to use a single one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment