-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: address warnings in test_checkers #4686
Comments
Hi @terriko , |
Hello! @terriko ,I’d love to contribute to this issue! I've addressed and analyzed the deprecation warnings and will refactor the code to ensure compatibility with modern Python versions. My plan is: 🔄 Replace pkg_resources with importlib.metadata for handling package metadata. Looking forward to fixing this and submitting a PR soon! Let me know if there are any preferences or suggestions. Happy to collaborate! and contibute !🚀🔧 |
Hi @terriko, I’m excited to contribute to this issue! I've analyzed the warnings and identified that they stem from the deprecated usage of pkg_resources. To modernize the code and ensure future compatibility, I plan to: ✔️ Replace pkg_resources with importlib.metadata (for package metadata) and importlib.resources (for resource handling). Open-source contributions have been an exciting journey for me, and I’m eager to refine my skills while collaborating with this amazing community. I’ll begin working on this and submit a PR soon! Looking forward to any feedback or suggestions. Let’s build something awesome together! 🚀 |
@22f1001635 -- this is whatever github actions is using as python 3.10, so 3.10.6 may be a reasonable guess. I'm not sure if that's explicitly dumped in the logs but it should be easy to check somewhere? It's possible that you're not seeing it in other versions of python because it's only occurring in stuff that's listed as long tests. |
@terriko I reproduced the warnings on Python 3.10.16. The issue has been fixed, and a PR is coming soon. |
Description
It looks like we're still using some deprecated stuff from pkg_resources, which is understandable because cve-bin-tool is older than the current preferred way for handling certain things. But it's time to refactor and bring ourselves into the future! Here's the warnings:
I don't offhand know what we need to change to, but you should be able to figure it out by searching and reading the docs including the links they provided in the warning message above.
To reproduce
Steps to reproduce the behaviour:
LONG_TESTS=1 pytest test/test_checkers.py
Expected behaviour: no warnings
Actual behaviour: the warnings above apear
Anything else?
Feel free to add any other context here.
Short tips for new contributors:
Claiming issues:
The text was updated successfully, but these errors were encountered: