Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mismatch command line #4681

Open
terriko opened this issue Jan 8, 2025 · 1 comment
Open

test: mismatch command line #4681

terriko opened this issue Jan 8, 2025 · 1 comment
Labels
good first issue Good for newcomers tests

Comments

@terriko
Copy link
Contributor

terriko commented Jan 8, 2025

Description

We recently had an issue where the mismatch python files weren't being included so our instructions for running the mismatch utility separately didn't work. It would be nice to have a test to make sure that doesn't happen again I think an ideal test would build from the github repo and test the resulting python package to see that the file was included, and possibly check that the utility itself can be run. The default python build tools do require dependencies and will trigger downloads, so we probably want to put this in long tests only.

To reproduce

See: #4655

Version/platform info

N/A (all versions were affected)

Anything else?

If you've never done python packaging and you want to look at this, you may want to read the instructions on how to build and test a python package.

The build part starts here: https://packaging.python.org/en/latest/tutorials/packaging-projects/#generating-distribution-archives

You won't need to upload the package, so you'll want to skip the section below the one linked above.

@terriko terriko added bug Something isn't working tests good first issue Good for newcomers and removed bug Something isn't working labels Jan 8, 2025
@Prtm2110
Copy link
Contributor

Prtm2110 commented Feb 2, 2025

It would be nice to have a test to make sure that doesn't happen again I think an ideal test would build from the github repo and test the resulting python package to see that the file was included, and possibly check that the utility itself can be run.

@terriko I could be completely wrong here, but I think this won’t solve the exact issue we had because the GitHub repo's version with pip install . and testing on it will be incorrect (as it will still miss the kind of bug we encountered earlier). The mismatch module was working fine in the editable version, but the issue was in the Python packaging itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers tests
Projects
None yet
Development

No branches or pull requests

2 participants