Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer not actually backing up AI models when choosing Yes at back up models option at uninstallation #144

Open
syyrmb opened this issue Jan 11, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@syyrmb
Copy link

syyrmb commented Jan 11, 2025

Describe the bug

When uninstalling or reinstalling AL Playground, the installer will prompt to save a copy of current AI models, however, the "AI Playground_model_backup" folder will only have "llm" and "stable_diffusion" sub-folders which doesn't fully backup all your downloaded models. I assume this is not supposed behavior.

To Reproduce

Steps to reproduce the behavior:

  1. Download some models (dreamshaper-8, Juggernaut-XL-v9, etc.).
  2. uninstall/reinstall AI playground.
  3. Click Yes when prompted to back up models.
  4. Go to AI Playground_model_backup folder, and none of your downloaded model will be there.

Expected behavior

At above step 4, your downloaded models will be backup'ed. Preferably ComfyUI should also get a backup since it's a pain to download everything in China (there is no proxy setting in AI Playground control...not sure if I should open a feature request).

Environment (please complete the following information):

  • OS: [Windows 10 22H2 Build 19045.5247]
  • GPU: [Intel Arc A770 16G]

Additional context

This is a problem I encounter when I tried to reinstall AI Playground due to a ls_level_zero.exe error prompt. The supposed executable directory the prompt gives me is "AI Playground\resources\ai-backend-env\Library\bin\ls_level_zero.exe" but I can't find anything there, so I reinstalled AI Playground and every model is lost.

@syyrmb syyrmb added the bug Something isn't working label Jan 11, 2025
@Nuullll
Copy link
Contributor

Nuullll commented Jan 22, 2025

Thank you for bringing this issue to our attention. We apologize for the inconvenience and the loss of your model files.

We have identified the root cause of the problem in the original uninstaller script. Specifically, if the backup target directory already exists before the actual backup process begins, the backup would fail. You can view the relevant code here:

Rename "$INSTDIR\resources\service\models" "$2"

This issue has been addressed and fixed in our development branch. You can find the commit with the fix here: 31d3414.

However, please note that even when you install the newer version, the old uninstaller script (which contains the backup bug) will still be invoked to remove the existing installation. Therefore, you may still encounter this issue if your current installation version is <= v2.0.0-alpha-preview. In other words, if your current installation version is <= v2.0.0-alpha-preview, the safer way to keep your files is to perform a manual backup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants