Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT]: Bump go-github to v60 #2187

Closed
1 task done
nayuta opened this issue Mar 7, 2024 · 5 comments · May be fixed by nayuta/terraform-provider-github#1
Closed
1 task done

[MAINT]: Bump go-github to v60 #2187

nayuta opened this issue Mar 7, 2024 · 5 comments · May be fixed by nayuta/terraform-provider-github#1
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Comments

@nayuta
Copy link

nayuta commented Mar 7, 2024

Describe the need

Bump go-github from v57 to v60

This bump has some breaking changes to fix.

These changes seem to feature changes and bug fixes but need triage.

SDK Version

No response

API Version

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@nayuta nayuta added Status: Triage This is being looked at and prioritized Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR labels Mar 7, 2024
@kfcampbell kfcampbell added Status: Up for grabs Issues that are ready to be worked on by anyone and removed Status: Triage This is being looked at and prioritized labels Mar 8, 2024
@nayuta nayuta mentioned this issue Mar 9, 2024
4 tasks
@nayuta
Copy link
Author

nayuta commented Mar 14, 2024

@kfcampbell I already created the PR for this. Could you tell me about the next step?

@kfcampbell
Copy link
Member

Hi, thanks for doing that. What happens next is @nickfloyd or I will review it when we can, which is usually (but not always) a Monday or a Friday. Please be patient, we don't get as much time as we'd like to do this. Thank you for contributing!

@nayuta
Copy link
Author

nayuta commented Mar 15, 2024

Hi, thanks for replying. I got about the situation. I'm always grateful to you for maintaining the repository!

@JamieB101
Copy link

hey @kfcampbell, hope you're having a good week. Quick question, is this something that you'll be looking at soon? I only ask because it seems to be holding up the Custom Properties tf provider which we're super-keen to use!
#1956

@kfcampbell
Copy link
Member

Closing this issue as #2304 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
3 participants