fix: OpenAI prompt details and completion tokens details missing from total usage #1105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The change solve
create_with_completion
failing to output the correct token usage:total_usage: CompletionUsage
now is initialized with bothPromptTokenDetails
andCompletionTokenDetails
fields. I am aware that this implies overriding to some degree the optionality of this attributes, nevertheless I think0
is a good alias for the information thatNone
in this context conveys.and this values are respectfully filled out whenever possible
Related Issue
Important
Fixes token usage reporting by initializing
CompletionUsage
with token details and updating aggregation inretry.py
andutils.py
.CompletionUsage
withCompletionTokensDetails
andPromptTokensDetails
ininitialize_usage()
inretry.py
.update_total_usage()
inutils.py
to aggregateaudio_tokens
,reasoning_tokens
, andcached_tokens
.CompletionTokensDetails
andPromptTokensDetails
to imports inretry.py
.This description was created by for 60d549a. It will automatically update as commits are pushed.