Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Request and Issue templates make generic references to "model" #1107

Open
nathan-weinberg opened this issue May 21, 2024 · 2 comments
Open
Labels
bug Something isn't working question Further information is requested

Comments

@nathan-weinberg
Copy link
Member

T4R - generally we support users using one of two models in InstructLab - merlinite and granite - but various Pull Request and Issue templates just ask users about "model" inputs and outputs - we should make this clearer as to what users should actually be using for their taxonomy contributions

@nathan-weinberg nathan-weinberg added bug Something isn't working question Further information is requested labels May 21, 2024
@wking
Copy link
Contributor

wking commented May 21, 2024

Alternatively, we can ask them to specify which model they used or suggest they copy/paste the output that mentions that. Because today's Granite is presumably going to be a fair bit different from next year's Granite, and the goal with the taxonomy repo is to collect skills/knowledge that are useful somewhere, and not necessarily only skills that are useful for one particular model today. Or is there an expectation that we prune skills/knowledge that are no longer useful for one particular model today? Because I can see maintenance savings in that kind of pruning, but also a chance at making some potential user with a not-all-that-smart base model sad, and balancing the maintenance cost vs. potential use seems hard.

@lehors
Copy link
Contributor

lehors commented May 22, 2024

I agree with @wking that we should ask people which model they used (including the version). Getting that info makes it possible to implement various policies later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants