Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: expose parserOptions more #2530

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: expose parserOptions more #2530

wants to merge 1 commit into from

Conversation

ajuvercr
Copy link

This PR fixes #2529.

@ajuvercr ajuvercr requested a review from a team as a code owner October 15, 2024 09:21
@NSeydoux
Copy link
Contributor

As far as I understand, this does not achieve the intended effect: the introduced ParserOptions from n3 is different from the ParseOptions in the getSolidDataset options (see https://github.com/inrupt/solid-client-js/blob/main/src/resource/solidDataset.ts#L153). This PR adds a new type to the interface, but the passed option will never actually be used, it's just not incompatible with the existing API because it is an additive change.

I think switching to the solid-client ParseOption, and adding that to the API where you were adding ParserOption should get you where you in the right direction.

@ajuvercr
Copy link
Author

Thanks @NSeydoux for having a look!
I totally didn't see the difference between ParseOptions and ParserOptions, it should be all fixed and correct now

@ajuvercr
Copy link
Author

Could you have another look @NSeydoux ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose ParserOption on more places
2 participants
@ajuvercr @NSeydoux