From bd9f0b258e648b6644cb896c2e0b3d493226db37 Mon Sep 17 00:00:00 2001 From: Michael Eischer Date: Thu, 10 Oct 2024 18:29:43 +0200 Subject: [PATCH] outlook: fix temporary memory leak while listing events As the whole request body is read using io.ReadAll, thus the request can be freed immediately afterwards. --- internal/adapter/outlook_http/client.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/adapter/outlook_http/client.go b/internal/adapter/outlook_http/client.go index 5aa7fcb..273e670 100644 --- a/internal/adapter/outlook_http/client.go +++ b/internal/adapter/outlook_http/client.go @@ -46,7 +46,7 @@ func (o *OutlookClient) ListEvents(ctx context.Context, start time.Time, end tim } body, _ := io.ReadAll(resp.Body) - defer resp.Body.Close() + resp.Body.Close() var eventList EventList err = json.Unmarshal(body, &eventList) @@ -62,7 +62,7 @@ func (o *OutlookClient) ListEvents(ctx context.Context, start time.Time, end tim } body, _ := io.ReadAll(resp.Body) - defer resp.Body.Close() + resp.Body.Close() var nextList EventList err = json.Unmarshal(body, &nextList)