Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tendermint): Fix deserialization from serde_json::Value #1475

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

oblique
Copy link

@oblique oblique commented Nov 18, 2024

Fixes #1474

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@oblique
Copy link
Author

oblique commented Nov 18, 2024

Some questions:

  1. CowStr can also be used in any place of tendermint-rs that uses String::deserialize etc. Should I change all of them?
  2. Do you like CowStr or should I just use String?

@romac
Copy link
Member

romac commented Dec 11, 2024

Some questions:

  1. CowStr can also be used in any place of tendermint-rs that uses String::deserialize etc. Should I change all of them?

This can be done in a follow-up PR :)

  1. Do you like CowStr or should I just use String?

CowStr is fine!

@romac
Copy link
Member

romac commented Dec 11, 2024

Can you please add a changelog entry in the appropriate subdirectory in .changelog/? Then I'll gladly merge this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tendermint::Hash can not be used as a return value when used with jsonrpsee
2 participants