From 6d4e53856c2a8dbb13cd58f71ced01d5fe0b7b89 Mon Sep 17 00:00:00 2001 From: Mikhail Zabaluev Date: Tue, 19 Sep 2023 16:49:42 +0300 Subject: [PATCH] CI: doc build fix, update actions/checkout (#1355) * Switch the doc building toolchain to stable The docs now build on stable, and nightly triggers some bug with a dependency. * CI: update actions/checkout to v4 * CI: don't pass docsrs feature to cargo doc One dependency has docs that make nightly rustdoc fail, while others require nightly with the "docsrs" feature. --- .github/workflows/audit.yml | 2 +- .github/workflows/build.yml | 8 ++++---- .github/workflows/no-std.yaml | 4 ++-- .github/workflows/release.yml | 2 +- .github/workflows/rust.yml | 14 ++++++-------- .github/workflows/test.yml | 20 ++++++++++---------- 6 files changed, 24 insertions(+), 26 deletions(-) diff --git a/.github/workflows/audit.yml b/.github/workflows/audit.yml index d6ab94375..7c3e714d9 100644 --- a/.github/workflows/audit.yml +++ b/.github/workflows/audit.yml @@ -11,7 +11,7 @@ jobs: security_audit: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: rustsec/audit-check@v1.4.1 with: token: ${{ secrets.GITHUB_TOKEN }} diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 8e29b650c..b94540e40 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -21,14 +21,14 @@ jobs: tendermint: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: dtolnay/rust-toolchain@stable - run: cargo build-all build-light-client-wasm: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: dtolnay/rust-toolchain@stable with: targets: wasm32-unknown-unknown @@ -38,7 +38,7 @@ jobs: tools: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: dtolnay/rust-toolchain@stable - run: cargo build-tools @@ -46,7 +46,7 @@ jobs: generated-protos-compile: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: dtolnay/rust-toolchain@stable - name: Install protoc run: | diff --git a/.github/workflows/no-std.yaml b/.github/workflows/no-std.yaml index 74e5fe86c..b919c76ae 100644 --- a/.github/workflows/no-std.yaml +++ b/.github/workflows/no-std.yaml @@ -9,7 +9,7 @@ jobs: name: Check no_std panic conflict runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: dtolnay/rust-toolchain@stable - run: | cd tools/no-std-check @@ -21,7 +21,7 @@ jobs: # name: Check no_std substrate support # runs-on: ubuntu-latest # steps: - # - uses: actions/checkout@v3 + # - uses: actions/checkout@v4 # - uses: dtolnay/rust-toolchain@stable # - run: | # cd tools/no-std-check diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 3d7c4e5fa..e9f1c2ecc 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -20,7 +20,7 @@ jobs: release: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: dtolnay/rust-toolchain@stable - name: Publish crates run: ./release.sh diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 6b2e84701..a879f621b 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -21,7 +21,7 @@ jobs: fmt: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: dtolnay/rust-toolchain@stable - run: cargo fmt --all -- --check @@ -29,7 +29,7 @@ jobs: clippy-json-output: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: dtolnay/rust-toolchain@stable with: components: clippy @@ -42,7 +42,7 @@ jobs: clippy-tools-output: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: dtolnay/rust-toolchain@stable with: components: clippy @@ -55,8 +55,6 @@ jobs: docs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - - uses: dtolnay/rust-toolchain@nightly # regression prevents docs from building on stable - - env: - RUSTDOCFLAGS: "--cfg docsrs" - run: cargo doc --all-features + - uses: actions/checkout@v4 + - uses: dtolnay/rust-toolchain@stable + - run: cargo doc --all-features diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index eb85ca937..4461986a0 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -21,7 +21,7 @@ jobs: default-features: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: dtolnay/rust-toolchain@stable - run: cargo test @@ -32,28 +32,28 @@ jobs: tendermint: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: dtolnay/rust-toolchain@stable - run: cargo test-all-features -p tendermint tendermint-rpc: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: dtolnay/rust-toolchain@stable - run: cargo test-all-features -p tendermint-rpc tendermint-proto: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: dtolnay/rust-toolchain@stable - run: cargo test-all-features -p tendermint-proto tendermint-light-client: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: dtolnay/rust-toolchain@stable # NOTE: We test with default features to make sure things work without "unstable". - name: Test with default features @@ -65,7 +65,7 @@ jobs: tendermint-light-client-js: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Install wasm-pack run: curl https://rustwasm.github.io/wasm-pack/installer/init.sh -sSf | sh - run: wasm-pack test --headless --chrome ./light-client-js/ @@ -74,14 +74,14 @@ jobs: tendermint-test: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: dtolnay/rust-toolchain@stable - run: cargo test-all-features -p tendermint-test tendermint-testgen: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: dtolnay/rust-toolchain@stable - run: cargo test-all-features -p tendermint-testgen @@ -95,7 +95,7 @@ jobs: - 26657:26657 - 26660:26660 steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: dtolnay/rust-toolchain@stable - run: cargo test-all-features --manifest-path tools/kvstore-test/Cargo.toml -- --nocapture env: @@ -104,7 +104,7 @@ jobs: nightly-coverage: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: dtolnay/rust-toolchain@nightly with: components: llvm-tools-preview