Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] PE sign InfluxDB executables #25625

Open
jdstrand opened this issue Dec 6, 2024 · 0 comments
Open

[Feature request] PE sign InfluxDB executables #25625

jdstrand opened this issue Dec 6, 2024 · 0 comments

Comments

@jdstrand
Copy link
Contributor

jdstrand commented Dec 6, 2024

We currently currently sign files in https://www.influxdata.com/downloads/ with a detached signature (.asc file) for pgp/gpg to verify. This is all fine.

Only the telegraf Windows binary (PE executable) is signed using Microsoft code-signing (eg, authenticode). See:

We aren't currently doing this for InfluxDB (1.x, 2.x or 3.x). Eg, if I unzip the influxdb2-2.7.11-windows.zip I see:

$ osslsigncode extract-signature ./influxd.exe ./out
PE file does not have any signature: ./influxd.exe
Failed
[255]

Adding PE signing to all downloadable executables for Windows would reduce barriers to entry for people using them in certain environments (eg, some site-specific security policies require binaries signed in the manner). The proper way to do this is to update https://github.com/influxdata/code-sign (private repo) to support PE signing (eg, in addition to detached signature, apt InRelease files and rpm signing) and then adjust the InfluxDB CircleCI jobs for 1.x, 2.x and 3.x to send the windows binary to be signed (similar to how we do rpm). Once that is done, it should be trivial to adjust all the different projects to start using this and migrate telegraf to it.

cc @gunnaraasen, @davidby-influx, @srebhan

References:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant