Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove /api/v3/write #25611

Open
mgattozzi opened this issue Dec 3, 2024 · 2 comments · May be fixed by #25623
Open

Remove /api/v3/write #25611

mgattozzi opened this issue Dec 3, 2024 · 2 comments · May be fixed by #25623
Labels
good-first-issue v3

Comments

@mgattozzi
Copy link
Contributor

Problem

Currently we have the write API with v3 but with the changes in #25596, there's no real advantage to having this API for now.

Proposed solution

We want to just remove this for now ahead of our first public release as we don't want to be committed to this API and have users depend on it. We can add this API back later if we want to do something that's not line protocol oriented or we want something else.

Alternatives

None as we've discussed in #25596 that we want to get rid of this

Additional context

The entry point for this API is here:

influxdb/influxdb3_server/src/http.rs

Line 1379 in f23aa0d

(Method::POST, "/api/v3/write") => http_server.write_v3(req).await,

This line will need to be removed as well as the function itself:

influxdb/influxdb3_server/src/http.rs

Lines 432 to 436 in f23aa0d

async fn write_v3(&self, req: Request<Body>) -> Result<Response<Body>> {
let query = req.uri().query().ok_or(Error::MissingWriteParams)?;
let params: WriteParams = serde_urlencoded::from_str(query)?;
self.write_lp_inner(params, req, false, true).await
}

There shouldn't be much else needed beyond fixing up some tests/removing them possibly and the compiler should guide that pretty easily.
@mgattozzi mgattozzi mentioned this issue Dec 3, 2024
Merged
@hiltontj
Copy link
Contributor

hiltontj commented Dec 3, 2024

We will need upstream issues in IOx to remove the related code from influxdb3_core as well. Namely,

  • the v3 module in the influx_line_protocol crate along with the "v3" feature flag in that crate
  • the "v3" related features in the schema crate

I think that is the extent of it, but anything used for this API is behind a "v3" feature flag so should be easy to root out if not included above. I am happy to go and open that issue upstream.

@hiltontj
Copy link
Contributor

hiltontj commented Dec 3, 2024

Related issue in IOx: https://github.com/influxdata/influxdb_iox/issues/12971

Prerit008 added a commit to Prerit008/influxdb that referenced this issue Dec 6, 2024
@Prerit008
Fixes influxdata#25611: Remove unused v3 write API and associated fun…
61b8314 
…ction
@Prerit008 Prerit008 linked a pull request Dec 6, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #25611: Remove unused v3 write API and associated function Prerit008/influxdb
2 participants
@mgattozzi @hiltontj