Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #25611: Remove unused v3 write API and associated function #25623

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixes #25611: Remove unused v3 write API and associated function #25623

wants to merge 1 commit into from

Conversation

Prerit008
Copy link

Closes #25611

Proposed changes:

This pull request removes the unused v3 write API and its associated function, as discussed in #25611 . Since the v3 write API currently offers no significant advantage and isn't aligned with the immediate goals of the project, we are removing it ahead of the first public release to avoid committing to this API prematurely.

Changes made

  1. Removed the entry point for the v3 write API: 
    (Method::POST, "/api/v3/write") => http_server.write_v3(req).await,
  2. Deleted the write_v3 function located in influxdb/influxdb3_server/src/http.rs: 
     async fn write_v3(&self, req: Request<Body>) -> Result<Response<Body>> { 
      let query = req.uri().query().ok_or(Error::MissingWriteParams)?; 
      let params: WriteParams = serde_urlencoded::from_str(query)?; 
      self.write_lp_inner(params, req, false, true).await 
 }
  3. Updated and/or removed associated tests to align with these changes.

✅ I've read the contributing section of the project README.
✅ Signed CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove /api/v3/write
1 participant
@Prerit008