You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This isn't the most efficient as we're changing an Arc<str> into an owned String and creating a Vec. However, the comparison where it's used in is comparing against a Vec<&str>. We can't use the lookup method on the ColumnId to get an Arc<str> and turn it into an &str without facing issues with the type system. We also can't return a slice easily either.
Our best bet is to cache the names of the columns as a Vec<String> in the TableDefinition and to return an &[&str] instead of a Vec<String>. Since this is a bit invasive I've split this off into a separate ticket.
The text was updated successfully, but these errors were encountered:
As part of #25596 I changed the
series_key
method to look like thisinfluxdb/influxdb3_catalog/src/catalog.rs
Lines 1137 to 1142 in 719d9c4
This isn't the most efficient as we're changing an
Arc<str>
into an owned String and creating a Vec. However, the comparison where it's used in is comparing against a Vec<&str>. We can't use the lookup method on theColumnId
to get anArc<str>
and turn it into an&str
without facing issues with the type system. We also can't return a slice easily either.Our best bet is to cache the names of the columns as a
Vec<String>
in theTableDefinition
and to return an &[&str] instead of aVec<String>
. Since this is a bit invasive I've split this off into a separate ticket.The text was updated successfully, but these errors were encountered: