fix(boilerplate): add header height calculation to keyboard avoidance #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will be testing this tomorrow, thanks for the contribution! |
|
@abtonc would you mind providing some before/after screenshots or video or supply a repo with an example? |
|
Here is a demo video from my current project (I switched to the branch with fix in this pr when refreshing text appeared.). Simulator.mp4This page uses ignite's useHeader hook, and the button on the bottom has I would love to provide a repo but this is a NDA'd project, so can't post it here. I can give you access to the repo if you can text me on twitter @frankcalise. Hope this was helpful, let me know if you need anything else. |
abtonc
force-pushed
the
fix/keyboard-avoiding-with-header
branch
from
57ccbc8
to
04a2a0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify the following:
yarn testjest tests pass with new tests, if relevantREADME.mdhas been updated with your changes, if relevantDescribe your PR
Fixes #2351. This bug is caused by react-navigation's header feature. Adding the height of the header to offset fixes the issue. (check this stackoverflow answer)