[Bug]: HTTP API delete_chunks:Inconsistent Behavior: chunk_ids=[] Deletes All Chunks in Infinity But None in Elasticsearch

[asiroliu]

Self Checks

• I have searched for existing issues search for existing issues, including closed ones.
• I confirm that I am using English to submit this report (Language Policy).
• Non-english title submitions will be closed directly ( 非英文标题的提交将会被直接关闭 ) (Language Policy).
• Please do not modify this template :) and fill in all the required fields.

RAGFlow workspace code commit ID

x

RAGFlow image version

166d24a3c485(infiniflow/ragflow:nightly)

Other environment information

Actual behavior

When passing an empty array chunk_ids=[] to the delete chunks API:

With DOC_ENGINE=infinity: Deletes ALL chunks under the document
With DOC_ENGINE=elasticsearch: Performs NO deletion
This inconsistency between engines may lead to accidental data loss.

Expected behavior

No response

Steps to reproduce

1. Deploy RAGFlow with DOC_ENGINE=infinity

DOC_ENGINE=infinity docker compose -f docker/docker-compose.yml up -d

2. delete chunks with chunk_ids=[]

payload = {"chunk_ids": []}
requests.delete(f'http://127.0.0.1:9380/api/v1/datasets/{dataset_id}/documents/{document_id}/chunks', json=payload)


3. The returned response is as follows:

{'code': 102, 'message': 'rm_chunk deleted chunks 5, expect 0'}


4. Deploy RAGFlow with DOC_ENGINE=elasticsearch

docker compose -f docker/docker-compose.yml up -d

2. delete chunks with chunk_ids=[]

payload = {"chunk_ids": []}
requests.delete(f'http://127.0.0.1:9380/api/v1/datasets/{dataset_id}/documents/{document_id}/chunks', json=payload)


3. The returned response is as follows:

{'code': 0, 'message': 'delete 0 chunks'}

Additional information

No response

[dosubot]

@asiroliu Hello there! I'm here to help you with any bugs, questions, or contributions you might have. Let's tackle this issue together!

The issue you're experiencing is due to inconsistent behavior in the delete_chunks API when handling an empty chunk_ids array, depending on the document engine used. For DOC_ENGINE=infinity, it deletes all chunks, while for DOC_ENGINE=elasticsearch, it performs no deletion.

This inconsistency can indeed lead to unintended data loss when using Infinity. To address this, you might consider implementing a check in the API to ensure that an empty chunk_ids array does not trigger a deletion of all chunks, regardless of the document engine. This would align the behavior across different engines and prevent accidental deletions.

Unfortunately, I couldn't find specific documentation or code comments within the repository that explain the intended behavior for this scenario. It might be beneficial to review the logic in the delete_chunks API implementation for both engines to ensure consistent handling of empty inputs.

To continue talking to Dosu, mention @dosu.

---

^{Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Bug Report | Other}

[asiroliu]

@liwenju0
Thank you for your latest commit. Currently, both Infinity and Elasticsearch backends correctly delete all chunks when receiving an empty array. However, we've noticed a minor issue - the response returns code=102 when it should return code=0. The corresponding message should also be updated to match this successful operation status.

{"code": 102, "message": "rm_chunk deleted chunks 5, expect 0"}