Skip to content
This repository was archived by the owner on May 25, 2023. It is now read-only.

Commit d943098

Browse files
committed
print IP{} as "zero IP" instead of "invalid IP"
It's a bit more precise. Signed-off-by: Josh Bleecher Snyder <[email protected]>
1 parent c639264 commit d943098

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

example_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ func ExampleIP_properties() {
4545
w.Flush()
4646
// Output:
4747
// String() Zone() IsZero() Is4() Is6() Is4in6()
48-
// invalid IP true false false false
48+
// zero IP true false false false
4949
// 192.0.2.3 false true false false
5050
// 2001:db8::68 false false true false
5151
// 2001:db8::68%eth0 eth0 false false true false

netaddr.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -821,7 +821,7 @@ func (ip IP) Prior() IP {
821821
func (ip IP) String() string {
822822
switch ip.z {
823823
case z0:
824-
return "invalid IP"
824+
return "zero IP"
825825
case z4:
826826
return ip.string4()
827827
default:

netaddr_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -861,7 +861,7 @@ func TestLessCompare(t *testing.T) {
861861
}
862862
sort.Slice(values, func(i, j int) bool { return values[i].Less(values[j]) })
863863
got := fmt.Sprintf("%s", values)
864-
want := `[invalid IP 1.2.3.4 8.8.8.8 ::1 ::1%foo ::2]`
864+
want := `[zero IP 1.2.3.4 8.8.8.8 ::1 ::1%foo ::2]`
865865
if got != want {
866866
t.Errorf("unexpected sort\n got: %s\nwant: %s\n", got, want)
867867
}
@@ -874,7 +874,7 @@ func TestIPStringExpanded(t *testing.T) {
874874
}{
875875
{
876876
ip: IP{},
877-
s: "invalid IP",
877+
s: "zero IP",
878878
},
879879
{
880880
ip: mustIP("192.0.2.1"),

0 commit comments

Comments
 (0)