-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default urwid bright-is-bold false #578
Labels
Comments
ghost
added
the
enhancement
label
Dec 30, 2022
I use kitty as well, and I've never noticed anything looking off.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
I've noticed urwid looks strange since I've started using "kitty" terminal. kitty comes with its own custom termaps, and so it's necessary to set
TERM=kitty
. In urwid, rather than using termap, they use a simple "not xterm" heuristic for their "bright is bold" flag. This results in a random half of all syntax becoming bold.https://github.com/urwid/urwid/blob/master/urwid/raw_display.py#L79
Describe the solution you'd like
A clear and concise description of what you want to happen.
Could we call
set_terminal_properties(bright_is_bold=False)
during startup? If you want to get fancy we could determine this boolean via termcap (as urwid should have done).The text was updated successfully, but these errors were encountered: