Sources ignore changes to properties which occur between setup() and map load

[mattico]

Hey, thanks for your work on this library!

vue-maplibre-gl/lib/components/sources/geojson.source.ts

Lines 53 to 78 in 7958f88

	setup(props, { slots }) {
	const cid = inject(componentIdSymbol)!,
	source = SourceLib.getSourceRef<GeoJSONSource>(cid, props.sourceId),
	registry = new SourceLayerRegistry(),
	opts = { ...props, type: "geojson" };
	provide(sourceIdSymbol, props.sourceId);
	provide(sourceLayerRegistry, registry);
	useSource(source, opts as SourceOptionProps, registry);
	watch(
	isRef(props.data) ? props.data : () => props.data,
	(v) => {
	source.value?.setData(
	(v as DataType) || { type: "FeatureCollection", features: [] },
	);
	},
	{ immediate: true },
	);
	return () => [
	createCommentVNode("GeoJSON Source"),
	source.value && slots.default ? slots.default({}) : undefined,
	];
	},

If a change is made to props.data between setup() and map load, the source isn't initialized, so the watch doesn't call setData(), and the inner MGL source doesn't get updated with the new data from the prop.

We ran into this with the GeoJSON source but it should affect most of the other sources which use this watch() + source.setX() pattern.

[francois2metz]

Hi,

Thanks for reporting the issue. I'll take a look to better understand the issue.