Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for deprecation of dynamic filters #47

Open
ichyo opened this issue Nov 26, 2019 · 0 comments
Open

Tracking issue for deprecation of dynamic filters #47

ichyo opened this issue Nov 26, 2019 · 0 comments

Comments

@ichyo
Copy link

ichyo commented Nov 26, 2019

This issue is for explaining deprecation of dynamic filters and for guide of migration to alternative.
(for indeed employee; See https://go.indeed.com/GLYMYNXNA for internal version of same document)

Summary

(test name based) dynamic filters are now deprecated and tag based sharing is the recommended way.

Steps to use tag based sharing

  1. Check what tests are currently shared by your dynamic filter
  2. Decide tag name for the tag based sharing.
  3. Put your tag name into metaTags field of all the tests you want to keep sharing. You can edit it in the usual test edit page. Please do not forget to promote them.
  4. Make a code change in dynamicfilters.json to use new filter.
  5. For new tests, please do not forget to add your tag name if you want to share it.

Why dynamic filters are deprecated?

The main reason is because it’s not possible to exclude tests once they are matched by the filter as it's not possible to change test name.

  • Too general pattern may match more tests than what they want. Such pattern may cause performance issues in the application, or may confuse the owners of mismatching tests.
  • Proctor Webapp cannot provide validation of promotion for dynamic clients because a user has no explicit control of which application to share the test.

What’s benefits of tag based sharing?

  • You can explicitly choose which application to share at any moment. You don’t have to follow naming pattern when creating a new test.
  • You can easily check what tests are shared by the specific filter. E.g. Go to proctor webapp and choose “MetaTags” in the search type and enter tag name in the search box.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant