Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConditionalComplete improvement: other state API is processing the signal/internal channel #290

Open
longquanzheng opened this issue Jul 4, 2023 · 0 comments
Labels
enhancement New feature or request large

Comments

@longquanzheng
Copy link
Contributor

In the first iteration of conditionalComplete in #282, it may lose the messages published to the InternalChannel or signal channel if there is another state still processing the messages from the channel. The other state could have got the messages from waitUntil and then still executing the execute API. In that case, the message is lost because execute is not completed in the other states.

As a workaround, user must ensure that channel for ConditionalComplete shouldn't be used in other states.

To "fix" or improve this behavior, we can add more logic in the workflow to check if other states are processing the messages and wait on the processing to be complete

@longquanzheng longquanzheng changed the title ConditionalComplete improvement: other state API is processing the internal/signal channel ConditionalComplete improvement: other state API is processing the internal channel Jul 6, 2023
@longquanzheng longquanzheng changed the title ConditionalComplete improvement: other state API is processing the internal channel ConditionalComplete improvement: other state API is processing the signal/internal channel Jul 6, 2023
@longquanzheng longquanzheng added enhancement New feature or request large labels Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request large
Projects
None yet
Development

No branches or pull requests

1 participant