Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Musl 1.2.5's new malloc #2277

Open
alfreb opened this issue Sep 7, 2024 · 1 comment
Open

Enable Musl 1.2.5's new malloc #2277

alfreb opened this issue Sep 7, 2024 · 1 comment
Labels
Enhancement libc / musl Issue related to integration with libc

Comments

@alfreb
Copy link
Contributor

alfreb commented Sep 7, 2024

It's supposedly faster, but issues were encountered with this enabled during upgrade to 1.2.5. See discussion in #2251.

@alfreb alfreb added Enhancement libc / musl Issue related to integration with libc labels Sep 7, 2024
@MagnusS
Copy link
Member

MagnusS commented Sep 7, 2024

To test with new malloc, remove "--with-malloc=oldmalloc" from:
https://github.com/includeos/IncludeOS/blob/v0.16.0-release/deps/musl/default.nix#L37
and
https://github.com/includeos/IncludeOS/blob/v0.16.0-release/deps/musl-unpatched/default.nix#L20

With malloc-ng, the kernel currently seems to enter a reboot cycle in libc init, here: https://github.com/includeos/IncludeOS/blob/master/src/platform/x86_pc/init_libc.cpp#L178

Control never comes back to kernel_main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement libc / musl Issue related to integration with libc
Projects
None yet
Development

No branches or pull requests

2 participants