refactor: improve OIDC server plugin error logging.

outofcoffee · outofcoffee · commit d4379bcd8d36 · 2025-08-23T20:51:46.000+01:00
diff --git a/external/plugins/oidc-server/auth.go b/external/plugins/oidc-server/auth.go
@@ -331,6 +331,8 @@ func (o *OIDCServer) renderLoginForm(sessionID, clientID string, errorMsg ...str
 }
 
 func (o *OIDCServer) renderError(errorCode, errorDescription string) shared.HandlerResponse {
+	o.logger.Error("OIDC error", "code", errorCode, "description", errorDescription)
+
 	body := fmt.Sprintf(`<!DOCTYPE html>
 <html>
 <head>
@@ -360,6 +362,8 @@ func (o *OIDCServer) renderError(errorCode, errorDescription string) shared.Hand
 }
 
 func (o *OIDCServer) redirectError(redirectURI, errorCode, errorDescription, state string) shared.HandlerResponse {
+	o.logger.Error("OIDC error", "code", errorCode, "description", errorDescription)
+
 	redirectURL, err := url.Parse(redirectURI)
 	if err != nil {
 		return o.renderError("server_error", "Invalid redirect URI")
diff --git a/external/plugins/oidc-server/token.go b/external/plugins/oidc-server/token.go
@@ -253,6 +253,8 @@ func (o *OIDCServer) validateAccessToken(tokenString string) (*AccessToken, erro
 }
 
 func (o *OIDCServer) tokenError(errorCode, errorDescription string) shared.HandlerResponse {
+	o.logger.Error("token error", "error", errorCode, "description", errorDescription)
+
 	errorResponse := TokenErrorResponse{
 		Error:            errorCode,
 		ErrorDescription: errorDescription,
diff --git a/external/plugins/oidc-server/userinfo.go b/external/plugins/oidc-server/userinfo.go
@@ -78,6 +78,8 @@ func (o *OIDCServer) handleUserInfo(args shared.HandlerRequest) shared.HandlerRe
 }
 
 func (o *OIDCServer) userinfoError(errorCode, errorDescription string, statusCode int) shared.HandlerResponse {
+	o.logger.Error("userinfo error", "error", errorCode, "description", errorDescription)
+
 	errorResponse := UserinfoErrorResponse{
 		Error:            errorCode,
 		ErrorDescription: errorDescription,

Original file line number	Diff line number	Diff line change
`@@ -253,6 +253,8 @@ func (o OIDCServer) validateAccessToken(tokenString string) (AccessToken, erro`
`253`	`253`	`}`
`254`	`254`
`255`	`255`	`func (o *OIDCServer) tokenError(errorCode, errorDescription string) shared.HandlerResponse {`
	`256`	`+ o.logger.Error("token error", "error", errorCode, "description", errorDescription)`
	`257`	`+`
`256`	`258`	`errorResponse := TokenErrorResponse{`
`257`	`259`	`Error: errorCode,`
`258`	`260`	`ErrorDescription: errorDescription,`
Original file line number	Diff line number	Diff line change
`@@ -78,6 +78,8 @@ func (o *OIDCServer) handleUserInfo(args shared.HandlerRequest) shared.HandlerRe`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`func (o *OIDCServer) userinfoError(errorCode, errorDescription string, statusCode int) shared.HandlerResponse {`
	`81`	`+ o.logger.Error("userinfo error", "error", errorCode, "description", errorDescription)`
	`82`	`+`
`81`	`83`	`errorResponse := UserinfoErrorResponse{`
`82`	`84`	`Error: errorCode,`
`83`	`85`	`ErrorDescription: errorDescription,`