Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data store source should be specified in model config file #407

Closed
alexdewar opened this issue May 31, 2024 · 1 comment · Fixed by #465
Closed

Data store source should be specified in model config file #407

alexdewar opened this issue May 31, 2024 · 1 comment · Fixed by #465
Assignees
Labels
question Further information is requested

Comments

@alexdewar
Copy link
Contributor

As the version of the data files used is a crucial part of the model run, I think really the path to the data source should be in the config file rather than specified as a command-line argument (or better still, as a URL: #364).

Do you agree, @jamesturner246?

@alexdewar alexdewar added the question Further information is requested label Jun 3, 2024
@jamesturner246
Copy link
Contributor

Sounds sensible! 👍

alexdewar added a commit that referenced this issue Jul 1, 2024
As of now, passing in the data source via a command-line argument is still supported, but deprecated. If users pass the data source in this way, a warning will be emitted.

Closes #407. Closes #365.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants