Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UMBRELLA] Generalise form 'static' and 'dynamic' risk factor models #231

Open
4 tasks
jamesturner246 opened this issue Oct 20, 2023 · 2 comments
Open
4 tasks
Assignees
Labels

Comments

@jamesturner246
Copy link
Contributor

jamesturner246 commented Oct 20, 2023

For context, in existing HealthGPS speak, static means initialise and dynamic means update.

The concept of the 'static' and the 'dynamic' risk factor models is already a little cloudy.

Some Dynamic models also do initialisation, and vice versa. Both model types have generate_ and update_risk_factors methods. So why not relax the restriction of having static and dynamic models, and just use the generate and update methods of both where appropriate?

This would also allow us to create as many risk factor models as we like, and stop polluting our models with hacky 'extras' where needed.

Also perhaps some way of grouping these modules, akin to the current separation of risk factor, demographic, analysis classes.

Tasks

@dalonsoa
Copy link
Contributor

dalonsoa commented Nov 2, 2023

Is this related to #194?

@jamesturner246
Copy link
Contributor Author

Related, but opposite ideas. @israel-vieira was rightfully against this change because modularity of model components would decrease with such a change -- i.e. models would become more bloated. This change seeks to reverse that by having separate modules for each unit computation -- i.e. the opposite of what #194 proposes. I will close #194, to avoid confusion.

@jamesturner246 jamesturner246 changed the title Generalise form 'static' and 'dynamic' risk factor models [UMBRELLA] Generalise form 'static' and 'dynamic' risk factor models May 7, 2024
@jamesturner246 jamesturner246 self-assigned this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🏗 In progress
Development

No branches or pull requests

2 participants